Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quit chan from Manager #61

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

jholdstock
Copy link
Member

Make the main loop of the Manager a blocking func which accepts a context. Shutdown the Manager when the context is canceled.

This slightly alters the semantics of the code but in a way that has functionally no impact. Previously the Tickers which update the Manager would only be stopped after the HTTP server and creeper had stopped, but now they are stopped immediately when the context is canceled.

@jholdstock jholdstock force-pushed the rm-quit branch 2 times, most recently from 92ea395 to a7c706c Compare October 3, 2023 09:19
Make the main loop of the Manager a blocking func which accepts a
context. Shutdown the Manager when the context is canceled.

This slightly alters the semantics of the code but in a way that has
functionally no impact. Previously the Tickers which update the Manager
would only be stopped after the HTTP server and creeper had stopped, but
now they are stopped immediately when the context is canceled.
manager.go Show resolved Hide resolved
@davecgh davecgh merged commit 15fec47 into decred:master Oct 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants